Skip to content

Additional Warning/Hardening Test in CI#3568

Open
Easton97-Jens wants to merge 5 commits into
owasp-modsecurity:v3/masterfrom
Easton97-Jens:v3/master-workflows
Open

Additional Warning/Hardening Test in CI#3568
Easton97-Jens wants to merge 5 commits into
owasp-modsecurity:v3/masterfrom
Easton97-Jens:v3/master-workflows

Conversation

@Easton97-Jens

Copy link
Copy Markdown
Contributor
  • I added a separate CI workflow/build job for ModSecurity v3 to make compiler warnings and hardening-related issues visible earlier in the development process.
  • The job intentionally builds ModSecurity with stricter GCC warning flags such as -Wall, -Wextra, -Wformat, and -Wformat-security.
  • The run currently operates in a warn-only mode so existing warnings become visible in CI without immediately failing the entire workflow because of -Werror.
  • This helps detect potential issues and regressions early and allows them to be fixed proactively before they appear in Fedora/RHEL packaging or downstream builds.
  • In addition, all relevant compiler, linker, and configure flags are printed in the CI logs to improve transparency and reproducibility of the build environment.
  • The long-term goal is to continuously reduce warnings and hardening issues and eventually re-enable stricter error handling (-Werror).

#3567

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an additional CI job intended to surface GCC warnings and common hardening-related build issues for ModSecurity v3 earlier in the development cycle, while keeping the job “warn-only” to avoid immediately breaking CI.

Changes:

  • Introduces a new “ModSecurity v3 (warn-only hardening build)” job on Ubuntu 24.04.
  • Builds with stricter compiler/linker flags and prints toolchain + build flag configuration to CI logs.
  • Auto-detects and installs the latest libluaX.Y-dev package before building.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci_new.yml Outdated
Comment thread .github/workflows/ci_new.yml
Comment thread .github/workflows/ci_new.yml
Comment thread .github/workflows/ci_new.yml
Comment thread .github/workflows/ci_new.yml
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants